Refactor zstd decoder #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up error returns to cancel when context is cancelled.
dnwe
pushed a commit
to bgreenlee/sarama
that referenced
this pull request
Dec 21, 2022
An upstream change in klauspost/compress#498 changed the default decoder concurrency from GOMAXPROCS to a maximum of 4. Explicitly pass a value of 0 via WithDecoderConcurrency so that GOMAXPROCS is used by default again.
dnwe
pushed a commit
to IBM/sarama
that referenced
this pull request
Dec 21, 2022
An upstream change in klauspost/compress#498 changed the default decoder concurrency from GOMAXPROCS to a maximum of 4. Explicitly pass a value of 0 via WithDecoderConcurrency so that GOMAXPROCS is used by default again.
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR;
Streams can now be decoded without goroutines using
WithDecoderConcurrency(1).WithDecoderConcurrency(4)is now default. If you need more concurrentDecodeAlloperations, useWithDecoderConcurrency(0).Goroutines exit when streams have finished reading (either error or EOF).
Designed and tested to be compatible, but test before committing upgrade.
Changes
Goroutines will now only be created on demand, and
WithDecoderConcurrency(1)is now strictly synchronized.Decompression will typically be about 2x faster when using multiple goroutines, and will prepare input for the upstream reader async to reads. This can lead to ~3x faster input in total than using no goroutines.
New default is now
WithDecoderConcurrency(4)(or less, if GOMAXPROCS is less). Beyond 4, there is little benefit for streaming decompression.WithDecoderConcurrency(1).Fixes #477